[Webkit-unassigned] [Bug 147961] Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with repositories other than "openSource" and "internal".

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147961

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258859|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 258859
  --> https://bugs.webkit.org/attachment.cgi?id=258859
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258859&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:172
> +                if (shouldAddDivider)
> +                    this._addDividerToPopover(content);
>  
> -        if (linesForOpenSource.length && linesForInternal.length)
> -            this._addDividerToPopover(content);
> +                for (var i = 0; i != lines.length; ++i)
> +                    content.appendChild(lines[i]);
>  

This is not correct because we always add a divider regardless of whether there were popover lines.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150813/6598c3eb/attachment.html>