[Webkit-unassigned] [Bug 147830] Cover memory cache subresource validation policy with cache tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147830

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258891|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 258891
  --> https://bugs.webkit.org/attachment.cgi?id=258891
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258891&action=review

Nice!

> Source/WebCore/loader/FrameLoader.h:288
> +    void setStrictRawResourceValidationPolicyDisabledForTesting(bool b) { m_isStrictRawResourceValidationPolicyDisabledForTesting = b; }

I'd use a real word instead of "b" here.

> Source/WebCore/loader/FrameLoader.h:289
> +    bool isStrictRawResourceValidationPolicyDisabledForTesting() { return m_isStrictRawResourceValidationPolicyDisabledForTesting; }

strictRawResourceValidationPolicyIsDisabledForTesting would result in better grammar in conditional constructs.

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:699
> +    // FIXME: We should have same cache policy for all resource types.

It is good to add a FIXME here. It would be even more helpful to explain why.

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:701
> +        bool strictPolicyDisabled = frame()->loader().isStrictRawResourceValidationPolicyDisabledForTesting();

When we use frame() elsewhere in this function, it's passed down to logMemoryCacheResourceRequest, which has a null check.

It seems that frame can't be null, yet I wanted to call your attention to the fact that the patch adds what looks like the first unchecked use of frame in this function.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150813/cd900314/attachment.html>