[Webkit-unassigned] [Bug 147938] Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories other than "openSource" and "internal".

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147938

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258828|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 258828
  --> https://bugs.webkit.org/attachment.cgi?id=258828
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258828&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:84
> +        for (var i = 0; i < Dashboard.sortedRepositories.length; i++) {
> +            var repository = Dashboard.sortedRepositories[i];

Notice that Dashboard.sortedRepositories is a getter function. We should cache Dashboard.sortedRepositories in a local variable instead of computing it twice on each iteration.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:90
> +            if (!trac.latestRecordedRevisionNumber || trac.oldestRecordedRevisionNumber > trac.latestProductiveIteration) {

I take it you meant to write:

if (!trac.latestRecordedRevisionNumber || trac.oldestRecordedRevisionNumber > latestProductiveRevisionNumber)

(Notice that I substituted latestProductiveRevisionNumber for trac.latestProductiveIteration in the second disjunct).

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:96
> +            totalRevisionsBehind += trac.commitsOnBranch(branch,
> +                function(commit) { return commit.revisionNumber > latestProductiveRevisionNumber; }).length;

Please write this on one line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150812/186823a7/attachment-0001.html>