[Webkit-unassigned] [Bug 147796] Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories other than "openSource" and "internal".

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 12 11:29:35 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=147796

Jason Marcell <jmarcell at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258830|                            |commit-queue?
              Flags|                            |

--- Comment #12 from Jason Marcell <jmarcell at apple.com> ---
Comment on attachment 258830
  --> https://bugs.webkit.org/attachment.cgi?id=258830
Patch

At Daniel Bates' recommendation, added additional assertion that, if the previousIteration is non-null, the given repository is in previousIteration.revision.

Also at Daniel's recommendation, defined a local variable for repositoryName and removed an unnecessary if statement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150812/071f12bf/attachment.html>


More information about the webkit-unassigned mailing list