[Webkit-unassigned] [Bug 147796] Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories other than "openSource" and "internal".

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 12 11:02:28 PDT 2015


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #258824|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #10 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 258824
  --> https://bugs.webkit.org/attachment.cgi?id=258824

View in context: https://bugs.webkit.org/attachment.cgi?id=258824&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:213
> +        console.assert(iteration.revision[repository.name]);

We should also assert that previousIteration.revision[repository.name] is non-null..

Also, I suggest that we cache the repository name (repository.name) in a local variable, say repositoryName, and reference this variable throughout this function instead of accessing repository.name repeatedly.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:272
> +            if (!iteration.revision[sortedRepositories[i].name])

For your consideration, I suggest defining a local variable, say repository, equal to sortedRepositories[i] and then referencing this local variable on this line and line 274 so that we do not compute sortedRepositories[i] twice.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:276
> +            if (!content)
> +                continue;

This if-statement is unnecessary given that we ensure the invariant of _revisionContentWithPopoverForIteration() on line 272.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150812/a7f7554d/attachment.html>

More information about the webkit-unassigned mailing list