[Webkit-unassigned] [Bug 147796] Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories other than "openSource" and "internal".

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147796

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258773|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 258773
  --> https://bugs.webkit.org/attachment.cgi?id=258773
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258773&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:214
> +        if (!iteration.revision[repository.name])
> +            return null;

We should assert this invariant instead of returning null as it represents a programmer mistake.

console.assert(iteration.revision[repository.name]);

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:274
> +            var content = this._revisionContentWithPopoverForIteration(iteration,
> +                previousDisplayedIteration, sortedRepositories[i]);

Please write this on one line.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:282
>          return fragment;

We may want to consider asserting that the fragment has at least one child node:

console.assert(fragment.childNodes.length);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150811/f7fc6b7f/attachment.html>