[Webkit-unassigned] [Bug 147805] Refactor webkitTrac to Dashboard.Repository.OpenSource.trac and internalTrac to Dashboard.Repository.Internal.trac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147805

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258759|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 258759
  --> https://bugs.webkit.org/attachment.cgi?id=258759
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258759&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:80
> +        webkitTrac = Dashboard.Repository.OpenSource.trac;
> +        internalTrac = Dashboard.Repository.Internal.trac;

These lines are declaring global variables named webkitTrac and internalTrac. Please make these local variables by explicitly adding the keyword var before the name of the variable such that these lines read:

var webkitTrac = Dashboard.Repository.OpenSource.trac;
var internalTrac = Dashboard.Repository.Internal.trac;

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:159
> +        webkitTrac = Dashboard.Repository.OpenSource.trac;
> +        internalTrac = Dashboard.Repository.Internal.trac;

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150811/2065bcd4/attachment-0001.html>