[Webkit-unassigned] [Bug 147802] Media Session: notify the UI process when media controls are enabled/disabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 11:04:52 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=147802

--- Comment #11 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #9)
> Comment on attachment 258682 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258682&action=review
> 
> > Source/WebCore/Modules/mediasession/MediaRemoteControls.h:67
> > +    MediaSession* m_session { nullptr };
> 
> You're storing a raw pointer to the MediaSession, but MediaRemoteControls is
> refCounted, so I see nothing that clears the pointer if MediaSession is
> destroyed before MediaRemoteControls.

Good catch. Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150811/93a59338/attachment.html>


More information about the webkit-unassigned mailing list