[Webkit-unassigned] [Bug 147880] [Win] Popup menus have incorrect placement when device scale factor != 1.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147880

--- Comment #3 from peavo at outlook.com ---
(In reply to comment #2)
> Comment on attachment 258717 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258717&action=review
> 
> r=me.
> 

Thanks!

> > Source/WebCore/platform/win/PopupMenuWin.cpp:291
> > +    if (!::ClientToScreen(hostWindow, &absoluteLocation))
> 
> Heh -- nice simplification! :-)
> 
> > Source/WebCore/platform/win/PopupMenuWin.cpp:317
> > +    Page* page = v->frame().page();
> 
> How about: "if (Page* page = v->frame().page()) ..." ?

I would have changed this, but now I see it's already in the commit queue :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150811/0cbbcc01/attachment.html>