[Webkit-unassigned] [Bug 147880] [Win] Popup menus have incorrect placement when device scale factor != 1.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147880

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258717|review?                     |review+, commit-queue+
              Flags|                            |

--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 258717
  --> https://bugs.webkit.org/attachment.cgi?id=258717
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258717&action=review

r=me.

> Source/WebCore/platform/win/PopupMenuWin.cpp:291
> +    if (!::ClientToScreen(hostWindow, &absoluteLocation))

Heh -- nice simplification! :-)

> Source/WebCore/platform/win/PopupMenuWin.cpp:317
> +    Page* page = v->frame().page();

How about: "if (Page* page = v->frame().page()) ..." ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150811/f3ab833d/attachment-0001.html>