[Webkit-unassigned] [Bug 147797] Media Session: generalize isFocusedContentMediaElementPlaying so it works with other playback attributes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 11:13:37 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=147797

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258625|review?                     |review-
              Flags|                            |

--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 258625
  --> https://bugs.webkit.org/attachment.cgi?id=258625
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258625&action=review

> Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h:44
>  enum {
> -    IsPlaying = 1 << 0
> +    IsPlaying                     = 1 << 0,
> +    IsPreviousTrackControlEnabled = 1 << 1,
> +    IsNextTrackControlEnabled     = 1 << 2,
>  };
>  typedef uint32_t WKMediaSessionFocusManagerPlaybackAttribute;

This should be enum WKMediaSessionFocusManagerPlaybackAttribute {  ... }
typedef uint32_t WKMediaSessionFocusManagerPlaybackAttributes;

> Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h:65
> +    WKMediaSessionFocusManagerPlaybackAttribute m_playbackAttributes { 0 };

WKMediaSessionFocusManagerPlaybackAttributes

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150810/41e9482d/attachment.html>


More information about the webkit-unassigned mailing list