[Webkit-unassigned] [Bug 147797] Media Session: generalize isFocusedContentMediaElementPlaying so it works with other playback attributes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 10:50:38 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=147797

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258538|review?                     |review-
              Flags|                            |

--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 258538
  --> https://bugs.webkit.org/attachment.cgi?id=258538
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258538&action=review

> Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h:66
> +    HashMap<WKMediaSessionFocusManagerPlaybackAttribute, bool> m_playbackAttributes;

Using a HashMap here is overkill, especially since you could put WKMediaSessionFocusManagerPlaybackAttribute into a bit mask.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150810/5aebbd00/attachment.html>


More information about the webkit-unassigned mailing list