[Webkit-unassigned] [Bug 144956] [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 8 15:02:52 PDT 2015


--- Comment #107 from Saam Barati <saambarati1 at gmail.com> ---
View in context: https://bugs.webkit.org/attachment.cgi?id=258572&action=review

Patch looks good to me. I'll ask pizlo to take a look as well.

> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:-4557
> -</Project>

Is this intended?

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:729
> +            return UnlinkedFunctionExecutable::create(m_vm, m_scopeNode->source(), body, isBuiltinFunction() ? UnlinkedBuiltinFunction : UnlinkedNormalFunction, constructAbility, variablesUnderTDZ, nullptr);

Not: if nullptr is already the default parameter here you can revert this line.

> Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:852
> +        case NewArrowFunction: {

This code is mostly the same as the NewFunction case. 
I think it's better to have these cases be the same and then
have them differ where they need to based on op == NewArrowFunction. 
I know this is a bit pedantic it's better for future proofing code.

> Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:1446
> +        case Allocation::Kind::NewArrowFunction: {

Ditto here.

> Source/JavaScriptCore/jit/JITOperations.cpp:945
> +EncodedJSValue static operationNewArrowFunctionCommon(ExecState* exec, JSScope* scope, JSCell* functionExecutable, EncodedJSValue thisValue, bool isInvalidated)

Nit: call this operationNewFunctionCommon

> Source/JavaScriptCore/jit/JITOperations.cpp:947
> +    UNUSED_PARAM(thisValue);

This seems wrong. You do use "thisValue"

> Source/JavaScriptCore/parser/Nodes.h:1880
> +    class ArrowFuncExprNode : public FuncExprNode {

I would either have his inherit from ExpressionNode or create a new
parent class that both FuncExprNode and ArrowFuncExprNode inherit from. 
This inheritance chain seems a bit weird.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150808/fb277590/attachment-0001.html>

More information about the webkit-unassigned mailing list