[Webkit-unassigned] [Bug 147393] Parse the entire WebAssembly modules
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 6 14:24:24 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=147393
Geoffrey Garen <ggaren at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #258288|review? |review+
Flags| |
--- Comment #17 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 258288
--> https://bugs.webkit.org/attachment.cgi?id=258288
Override JSCell::destroy()
View in context: https://bugs.webkit.org/attachment.cgi?id=258288&action=review
r=me
>> Source/JavaScriptCore/wasm/WASMModuleParser.cpp:108
>> + m_module->i32Constants().append(constant);
>
> I think this (and all appends below) can be uncheckedAppend() since we're reserving their space up front.
I agree.
> Source/JavaScriptCore/wasm/WASMModuleParser.cpp:138
> + m_module->signatures().append(signature);
Same here, and a few places below..
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150806/3e06013a/attachment-0001.html>
More information about the webkit-unassigned
mailing list