[Webkit-unassigned] [Bug 144956] [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144956

--- Comment #98 from Basile Clement <basile_clement at apple.com> ---
Comment on attachment 258384
  --> https://bugs.webkit.org/attachment.cgi?id=258384
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258384&action=review

The sinking-related stuff looks good to me.

> Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:2022
> +            ASSERT(locations.size() == isArrowFunction ? 3 : 2);

This is parsed as "ASSERT((locations.size() == isArrowFunction) ? 3 : 2);" and will always be true.

> Source/JavaScriptCore/dfg/DFGPromotedHeapLocation.h:50
> +    FunctionBoundThisPLoc

This is a nit, but I'd have called this ArrowFunctionBoundThisPLoc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150806/b6bdd054/attachment.html>