[Webkit-unassigned] [Bug 136415] AX: CSS table display styles can cause malformed, inaccessible AXTables to be exposed to the AX tree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136415

--- Comment #9 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 258318
  --> https://bugs.webkit.org/attachment.cgi?id=258318
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258318&action=review

> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:97
> +        // CSS display style can change the table hierarchy and cause the table to be malformed.

how does CSS display change the table hierarchy? it's a strange thing because the DOM looks ok

> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:103
> +                    if (is<AccessibilityTableRow>(*cellChild)) {

should this be more generic? why just table rows? what if we had a group -> group > row

would we catch that? is there something specific about this CSS variation that always creates this specific render tree hierarchy?

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:-1921
> -        { GridRole, NSAccessibilityGridRole },

what was the bug that this changed with? it seems correct to keep it as TableRole, but wondering how it broke

> LayoutTests/accessibility/mac/malformed-table.html:49
> +        shouldBe("columnCount", "2");

we need to check cellForColumnAndRow
we need get the elements out of the table through it's rows method, it's cells method and children method and verify that the role is correct for each child in those cases

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150805/8ca4f2fb/attachment.html>