[Webkit-unassigned] [Bug 147629] Media Session: add a focus manager that WebKit clients can use to access the focused media element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147629

--- Comment #8 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #7)
> Comment on attachment 258191 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258191&action=review
> 
> > Source/WebKit2/UIProcess/WebMediaSessionFocusManager.cpp:67
> > +    ASSERT(proxy);
> 
> No real need for this assert if you're just going to go ahead and
> dereference the null pointer two lines away.

Removed.

> 
> > Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h:38
> > +typedef std::tuple<WebPageProxy*, uint64_t> FocusedMediaElement;
> 
> might be clearer if this is a std::pair? then you don't have the fairly
> surprising std::get in the impl. Unless you're planning to add more
> components.

Switched to std::pair. Much cleaner.

> 
> > Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h:40
> > +class WebMediaSessionFocusManager: public API::ObjectImpl<API::Object::Type::MediaSessionFocusManager>, public WebContextSupplement {
> 
> space before the colon

Added.

> 
> > Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:-7626
> > -				15739BBD1B42042D00D258C1 /* WebUserMediaClient.h in Headers */,
> 
> This patch is doing a surprising about of xcodeproj reordering.

I just ran sort-xcode-project.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150804/b2d06121/attachment-0001.html>