[Webkit-unassigned] [Bug 147622] Refactor and improve TextIndicator to prepare for tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147622

--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 258167
  --> https://bugs.webkit.org/attachment.cgi?id=258167
preliminary patch for ews

View in context: https://bugs.webkit.org/attachment.cgi?id=258167&action=review

> Source/WebCore/page/TextIndicator.cpp:127
> +        if ((!renderer->isInline() || renderer->isReplaced()) && range.intersectsNode(node, ASSERT_NO_EXCEPTION))

Counting inline-but-replaced as "complex" is one of the big behavior changes.

> Source/WebCore/page/TextIndicator.cpp:188
> +    if (textRects.isEmpty()) {

This block (falling back to the bounding rect if we are asked to or if we end up with no text rects, and clipping said bounding rect to the visible rect) is one of the big behavior changes.

Humorously, this also lets us use TextIndicator for images on Mac, and it looks pretty reasonable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150804/3badfcb3/attachment.html>