[Webkit-unassigned] [Bug 147588] Media Session: let UI clients query whether a media element is paused

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147588

--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 258134
  --> https://bugs.webkit.org/attachment.cgi?id=258134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258134&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4072
> +    send(Messages::WebPageProxy::DidGetIsMediaElementPaused(callbackID, paused));

You could/should use the GenericCallback (specifically UnsignedCallback) mechanism here. Look around for examples. And probably your API (which oddly, I don't see here) should let people provide a block/function to call back (look at WKPageForceRepaint for an example, though that one doesn't return a value).

> Source/WebKit2/WebProcess/WebPage/WebPage.h:753
> +    void getIsMediaElementPaused(uint64_t, uint64_t);

No "get" here; we usually reserve that for functions with out arguments.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150803/93cbb6d2/attachment.html>