[Webkit-unassigned] [Bug 144440] New: Introduce UniquePropertyID class instead of using StringImpl* as uid

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144440

            Bug ID: 144440
           Summary: Introduce UniquePropertyID class instead of using
                    StringImpl* as uid
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: utatane.tea at gmail.com

To prevent the symbolized StringImpl* with the other string in their contents accidentally, I'm now planning to introduce a new class such as UniquePropertyID.

In UniquePropertyID, we prohibit comparison in their contents. Pointer comparison is only allowed. This is the replacement to StringImpl* uid usage.

The typical implementaion is the following...

class UniquePropertyID : private StringImpl {
    using existingSymbolAwareHash;
    using symbolAwareHash;
    using isSymbol;

    StringImpl* publicName()
    {
       return isSymbol() ? nullptr : this;
    }

    // Factory functions from StringImpl*.
    // ...
};

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150430/7432672f/attachment.html>