[Webkit-unassigned] [Bug 144436] Fix return code issue, check return code of safari process and dump results to log

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144436

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252040|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 252040
  --> https://bugs.webkit.org/attachment.cgi?id=252040
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252040&action=review

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:42
> +            _log.info('Safari process console output:\n\tstdout: %s\n\tstderr: %s' % self.safariProcess.communicate())

since stdout and stderr will contain multiple lines, I don't think it makes sense to indent by \t. Also, you might wanna add \n after :

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150430/7227e1ae/attachment.html>