[Webkit-unassigned] [Bug 144395] New: check-webkit-style: Don't complain about returning value from Objective-C method call in header

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 29 10:07:27 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144395

            Bug ID: 144395
           Summary: check-webkit-style: Don't complain about returning
                    value from Objective-C method call in header
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: aestes at apple.com, mitz at webkit.org

In Bug 144362, an inline method was added to SoftLinking.h that returned the value from an Objective-C method call:

+    inline className *alloc##className##Instance() \
+    { \
+        return [get_##framework##_##className##Class() alloc]; \
+    } \

However, check-webkit-style incorrectly flagged this as a style issue (see Bug 144362, Comment #24):

ERROR: Source/WebCore/platform/mac/SoftLinking.h:327:  Extra space before [  [whitespace/braces] [5]

Additional issues noted while investigating this:
- The category should be "whitespace/brackets", not "whitespace/braces".
- There is no test coverage for the code that checks for "whitespace/brackets".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150429/8ecaf96c/attachment.html>


More information about the webkit-unassigned mailing list