[Webkit-unassigned] [Bug 144360] New: [GTK] check-webkit-style fails due to missing import

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144360

            Bug ID: 144360
           Summary: [GTK] check-webkit-style fails due to missing import
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mario at webkit.org
                CC: cgarcia at igalia.com, mcatanzaro at igalia.com,
                    mrobinson at webkit.org

Today I hit the following error when trying to run the Tools/Scripts/check-webkit-style script in my Fedora 21 box:

  $ Tools/Scripts/check-webkit-style -g HEAD
  Traceback (most recent call last):
    File "Tools/Scripts/check-webkit-style", line 44, in <module>
      from webkitpy.style.main import CheckWebKitStyle
    File "/home/mario/work/WebKit/Tools/Scripts/webkitpy/style/main.py", line 27, in <module>
      import webkitpy.style.checker as checker
    File "/home/mario/work/WebKit/Tools/Scripts/webkitpy/style/checker.py", line 51, in <module>
      from checkers.python import PythonChecker
    File "/home/mario/work/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py", line 31, in <module>
      from webkitpy.thirdparty.autoinstalled.pylint import lint
    File "/home/mario/work/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 52, in <module>
      from pylint.interfaces import ILinter, IRawChecker, IASTNGChecker
  ImportError: cannot import name ILinter


After some investigation I finally found out that simply removing the pylint module would do the trick:

  $ sudo dnf remove pylint     # If installed from an rpm package

    or

  $ sudo pip uninstall pylint  # If installed via pip


Apparently, the problem is that the thirdparty/autoinstalled/pylint/lint.py file is trying to import the ILinter class from the pylint.interfaces module, which is provided by the thirdparty/autoinstalled/pylint/interfaces.py file as part of pylint 0.25.1. But pylint is also installed in the system under /usr/lib/python2.7, which is picked instead of the one inside thirdparty/autoinstalled... and this other one is a fairly different version (1.3.1 instead of 0.25.1) which, among other things, does not provide an ILinter class, causing the conflict.

So, there should be a way to prevent developers from having this type of conflicts, which can be quite confusing, or at least warning them in some way, so that they can have a working environment out of the box.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150428/cc68d425/attachment.html>