[Webkit-unassigned] [Bug 144320] URL paths should not be normalized when encoded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144320

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251834|review?                     |review+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 251834
  --> https://bugs.webkit.org/attachment.cgi?id=251834
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251834&action=review

> Source/WebCore/platform/text/TextEncoding.h:73
> +        enum EncodeNormalization { NormalizeBeforeEncoding, DoNotNormalizeBeforeEncoding };
> +        CString encode(StringView, UnencodableHandling, EncodeNormalization = NormalizeBeforeEncoding) const;

This is OK, but I’d also like us to consider doing the normalization with a separate function as the comment suggested. I’d like to understand how many different call sites there are that do this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150428/a88937e1/attachment.html>