[Webkit-unassigned] [Bug 144320] URL paths should not be normalized when encoded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144320

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251834|                            |review?
              Flags|                            |

--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 251834
  --> https://bugs.webkit.org/attachment.cgi?id=251834&action=review
Patch

There was a FIXME in TextEncoding::encode() wondering if encode(9 is the best place for the normalization. This bug proves, it indeed depends on the caller, but I think it's very convenient that it happens in encode(), so we can add a parameter to let the caller decide. I've added a text case to URL unit test.

**FAIL** URLTest.URLPathEnconding

../../Tools/TestWebKitAPI/Tests/WebCore/URL.cpp:97
Value of: url.lastPathComponent()
  Actual: test-ni%C3%B1o.png
Expected: encodeWithURLEscapeSequences(path)
Which is: test-nin%CC%83o.png

This is what happens without the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150428/1cea1059/attachment-0001.html>