[Webkit-unassigned] [Bug 143953] [Curl] Favicons loaded from disc cache are ignored.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 27 11:05:11 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=143953

--- Comment #12 from peavo at outlook.com ---
(In reply to comment #11)
> Comment on attachment 251346 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251346&action=review
> 
> > Source/WebCore/platform/network/ResourceHandleInternal.h:167
> > +        bool m_addedCacheValidationHeaders;
> 
> There is a trend towards using syntax like this:
> bool m_addedCacheValidationHeaders { false };
> If this is done with all the variables here, we could completely remove the
> other #if USE(CURL) above, but let's not touch the soup or cfnetwork code in
> this patch.

Thanks for reviewing :) Should I make this change for all the CURL members before landing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150427/7db3876d/attachment-0001.html>


More information about the webkit-unassigned mailing list