[Webkit-unassigned] [Bug 144259] Network Cache: Disk cache getting filled by YouTube video data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144259

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251743|review?                     |review+
              Flags|                            |

--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 251743
  --> https://bugs.webkit.org/attachment.cgi?id=251743
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251743&action=review

> Source/WebCore/platform/network/ResourceRequestBase.h:231
> +        Requester m_requester { Requester::Unspecified };

The data members just above are going out of their way to use bitfields, and here for something that takes only 2 bits we are not using one.

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:307
> +    bool isLikelyStreamingMedia = isXHR && (response.mimeType().startsWith("video/") || response.mimeType().startsWith("audio/"));

Is MIME type guaranteed to be lower case? I think it would be best to do this comparison in a case folding way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150427/11cb88c1/attachment.html>