[Webkit-unassigned] [Bug 144260] Fix viewport units in Media Queries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144260

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251737|review?                     |review+
              Flags|                            |

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 251737
  --> https://bugs.webkit.org/attachment.cgi?id=251737
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251737&action=review

> Source/WebCore/css/CSSPrimitiveValue.h:202
>          unsigned short type = primitiveType();
> -        return (type >= CSS_EMS && type <= CSS_PC) || type == CSS_REMS || type == CSS_CHS || isViewportPercentageLength();
> +        return isLength(type);

Should be done as a 1-liner.

> Source/WebCore/css/CSSPrimitiveValue.h:233
>          unsigned short type = primitiveType();
> -        return type >= CSS_DPPX && type <= CSS_DPCM;
> +        return isResolution(type);

Should be done as a 1-liner.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150427/e41ddbc5/attachment-0001.html>