[Webkit-unassigned] [Bug 142719] AX: richer text change notifications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142719

--- Comment #127 from Darin Adler <darin at apple.com> ---
Comment on attachment 251658
  --> https://bugs.webkit.org/attachment.cgi?id=251658
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251658&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:1079
> +    if (m_passwordNotificationsToPost.find(observableObject) == m_passwordNotificationsToPost.end()) {
> +        m_passwordNotificationsToPost.insert(observableObject);

This is not good, it’s a double lookup, once for find and then again for insert.

> Source/WebCore/accessibility/AXObjectCache.h:270
> +    template <class T = void> struct RefPtrCompare : std::binary_function<RefPtr<T>, RefPtr<T>, bool> {
> +        bool operator()(const RefPtr<T>& x, const RefPtr<T>& y) const { return x.get() < y.get(); }
> +    };

No, please don’t add adapters to use std::set. Use the set data structure from WTF: HashSet or perhaps for your use ListHashSet.

> Source/WebCore/accessibility/AXObjectCache.h:288
> +    std::set<RefPtr<AccessibilityObject>, RefPtrCompare<AccessibilityObject>> m_passwordNotificationsToPost;

Please don’t use std::set in WebKit. You need to use one of the WebKit collections. Given that we probably want these notifications to have a stable order, you should be using ListHashSet.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150426/03c513f0/attachment.html>