[Webkit-unassigned] [Bug 143939] Web Inspector: assertion failure when editing inline styles

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 12:30:55 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=143939

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251139|review?                     |review-
              Flags|                            |

--- Comment #4 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 251139
  --> https://bugs.webkit.org/attachment.cgi?id=251139
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251139&action=review

Looks good! Make these tweaks and I can r+ this.

> Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js:134
> +        if (styleSheet.isCssInlineStyle)

See below. This will need to change to: styleSheet.isInlineStyle()

> Source/WebInspectorUI/UserInterface/Models/CSSStyleSheet.js:87
> +    get isCssInlineStyle()

CSS should be all caps. No XMLHttpRequest precedent here. I don't think repeating CSS is needed either.

We also don't use is for getters. This should be a function.

I'd go with: isInlineStyle()

> Source/WebInspectorUI/UserInterface/Models/CSSStyleSheet.js:92
> +    markAsCssInlineStyle()

Ditto. Go with: markAsInlineStyle().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150424/e9b8eb8f/attachment.html>


More information about the webkit-unassigned mailing list