[Webkit-unassigned] [Bug 144016] Allow function allocation sinking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144016

--- Comment #9 from Filip Pizlo <fpizlo at apple.com> ---
(In reply to comment #6)
> Comment on attachment 251524 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251524&action=review
> 
> > Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:566
> > +                        Node* executable = m_insertionSet.insertConstant(
> > +                            nodeIndex + 1, node->origin, node->cellOperand());
> 
> You could add the cellOperand as a strong constant. This means doing:
> 
> m_insertionSet.insertConstant(nodeIndex + 1, node->origin,
> m_graph.freezeStrong(node->cellOperand()));

Actually, cellOperand() is a FrozenValue* and it's already strong. So the current code is correct and what I'm suggesting is wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150424/bac632f8/attachment.html>