[Webkit-unassigned] [Bug 143965] New: webkit-patch should try harder to upload to the right bug when -b is not passed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 20 14:12:29 PDT 2015


            Bug ID: 143965
           Summary: webkit-patch should try harder to upload to the right
                    bug when -b is not passed
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com

I used the following command to upload a patch to Bugzilla for the commit prior to my HEAD (@):

webkit-patch upload -g @^

The patch was uploaded to the wrong bug. It went to the bug specified in @ instead, even though that bug was not mentioned anywhere in the commit message or diff of @^. There was exactly one bug present in the commit diff (in a ChangeLog file); I would have expected the patch to be uploaded to that bug.

The problem might be that Git.changed_files() in git.py seems to return the set of files changed SINCE the specified commit, rather than the set of files changed BY that commit (so none of the files changed in the commit are included). That seems confusing. AbstractPatchUploadingCommand._bug_id() in upload.py reasonably assumes it returns the files changed in that commit, which means -g will never pick the right bug except when using -g @.

I've also noticed that webkit-patch post-commits is prone to choose wrong bugs, but that might be a separate issue.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150420/e7e91d28/attachment-0001.html>

More information about the webkit-unassigned mailing list