[Webkit-unassigned] [Bug 143964] New: OpenGLShims appears to have a dead store if GLES2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143964

            Bug ID: 143964
           Summary: OpenGLShims appears to have a dead store if GLES2
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebGL
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: joepeck at webkit.org
                CC: hausmann at webkit.org, joepeck at webkit.org,
                    noam at webkit.org

* SUMMARY
Bug 95556 / r127874 introduced some GLES2 handling. It looks like it would cause a dead store. The code should be cleaned up in some way, or there is an actual bug.

Currently the code looks like:
https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/OpenGLShims.cpp#L64

    static void* lookupOpenGLFunctionAddress(const char* functionName, bool* success = 0)
    {
        ...
        fullFunctionName = functionName;
        fullFunctionName.append("EXT");
        target = getProcAddress(fullFunctionName.utf8().data());

    #if defined(GL_ES_VERSION_2_0)
        fullFunctionName = functionName;
        fullFunctionName.append("ANGLE");
        target = getProcAddress(fullFunctionName.utf8().data());
        if (target)
            return target;

        fullFunctionName = functionName;
        fullFunctionName.append("APPLE");
        target = getProcAddress(fullFunctionName.utf8().data());
    #endif

        // A null address is still a failure case.
        if (!target && success)
            *success = false;

        return target;
    }

Note that the target assignment for "EXT" will just immediately get overwritten by the "ANGLE"/"APPLE" case if GL_ES_VERSION_2_0.

So either there is a bug and the "EXT" case should be getting used, or there is not a bug and this is unnecessary work and the "EXT" case should just be an #else.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150420/7facb5a8/attachment.html>