[Webkit-unassigned] [Bug 141950] Use std::unique_ptr instead of OwnPtr in ThreadGlobalData

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 20 09:58:39 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=141950

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #247594|                            |commit-queue+
              Flags|                            |

--- Comment #25 from Darin Adler <darin at apple.com> ---
Comment on attachment 247594
  --> https://bugs.webkit.org/attachment.cgi?id=247594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247594&action=review

>> Source/WebCore/loader/cache/CachedResourceRequestInitiators.h:35
>> +    CachedResourceRequestInitiators();
> 
> We want this to stay private for the same reason as EventNames(); it’s too easy to use it wrong by accidentally capitalizing the function name, so we need it to be private to prevent that kind of accident.

But really what we want it to get rid of this over-engineered collection of three strings entirely!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150420/36439d76/attachment.html>


More information about the webkit-unassigned mailing list