[Webkit-unassigned] [Bug 143872] [SOUP] Add initial implementation of NetworkProcess disk cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143872

--- Comment #8 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 251014
  --> https://bugs.webkit.org/attachment.cgi?id=251014
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251014&action=review

Awesome stuff Carlos!

> Source/WebKit2/NetworkProcess/cache/NetworkCacheBlobStorage.cpp:34
> +#include <fcntl.h>

Why this?

> Source/WebKit2/NetworkProcess/cache/NetworkCacheDataSoup.cpp:29
> +#if ENABLE(NETWORK_CACHE)

Don't we need some USE(SOUP) or PLATFORM(LINUX) and the like?

> Source/WebKit2/NetworkProcess/cache/NetworkCacheDataSoup.cpp:129
> +    ASSERT(map && map != MAP_FAILED);

Perhaps better to split this in 2 ASSERTs in order to better spot the actual cause of failure.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:58
> +    ASSERT(m_outputStream || m_inputStream || m_ioStream);

Same here about splitting the ASSERT

> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:82
> +    }

Can't we use Data directly instead of having to copy it from a SoupBuffer?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150420/65f8f6ff/attachment.html>