[Webkit-unassigned] [Bug 141950] Use std::unique_ptr instead of OwnPtr in ThreadGlobalData

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 19 22:20:07 PDT 2015


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #247594|review?                     |review+
              Flags|                            |

--- Comment #24 from Darin Adler <darin at apple.com> ---
Comment on attachment 247594
  --> https://bugs.webkit.org/attachment.cgi?id=247594

View in context: https://bugs.webkit.org/attachment.cgi?id=247594&action=review

> Source/WebCore/dom/EventNames.h:316
> +    // FIXME: The friend declaration to std::make_unique below does not work in windows port.

Windows should have a capital "W".

> Source/WebCore/loader/cache/CachedResourceRequestInitiators.h:35
> +    CachedResourceRequestInitiators();

We want this to stay private for the same reason as EventNames(); it’s too easy to use it wrong by accidentally capitalizing the function name, so we need it to be private to prevent that kind of accident.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150420/25ca00a8/attachment.html>

More information about the webkit-unassigned mailing list