[Webkit-unassigned] [Bug 140855] [ES6] Implement ES6 arrow function syntax

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140855

Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251129|review?                     |review-
              Flags|                            |

--- Comment #109 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 251129
  --> https://bugs.webkit.org/attachment.cgi?id=251129
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251129&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:3755
> +#if ENABLE(ES6_ARROWFUNCTION_SYNTAX)
> +        case op_new_arrow_func_exp: {
> +            FunctionExecutable* expr = m_inlineStackTop->m_profiledBlock->functionExpr(currentInstruction[3].u.operand);
> +            FrozenValue* frozen = m_graph.freezeStrong(expr);
> +            set(VirtualRegister(currentInstruction[1].u.operand),
> +                addToGraph(NewFunction, OpInfo(frozen), get(VirtualRegister(currentInstruction[2].u.operand))));
> +            NEXT_OPCODE(op_new_arrow_func_exp);
> +        }
> +#endif

This looks like it has to be wrong since you're not using operand 4.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150419/bd03429f/attachment.html>