[Webkit-unassigned] [Bug 143760] [W32] Compile-time assertion failure: RenderBlock_should_stay_small

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 17 17:36:34 PDT 2015


--- Comment #5 from LRN <lrn1986 at gmail.com> ---
(In reply to comment #4)
> (In reply to comment #3)
> > The patch originated from https://bugs.webkit.org/show_bug.cgi?id=133028 ,
> > where the original author used 4.8.something
> I still use this change with the webkit-2.4 branch at revision 182543.
> @LRN: so you've split my change (and other changes), but still want to
> receive credits for it? I'd say it's not a good habit by any means... :-/

The problem with the original bug was that it had multiple conflicting patches from 2 different authors, which made it difficult for upstream to sort through.

So i've split the changes into separate, manageable chunks and filed a lot bugs. I do admit that i haven't tracked copyrights or credit though (partially because many patches had no authorship information in them, i.e. were plain diffs; partially because i was more interested in figuring out which changes to apply and which to drop), and it did bother me somewhat when i was filing the bugs (especially on patches with lots of non-trivial code that i'm incapable of writing myself). So if you feel slighted, do comment where appropriate, and hopefully webkit devs will do something (no idea what's the protocol for such things; i assume there is one, because webkit seems to have lots of unapparent rules about committing).

Ironically, half of these changes probably won't make it past 2.4 anyway :(

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150418/bc56c16a/attachment-0001.html>

More information about the webkit-unassigned mailing list