[Webkit-unassigned] [Bug 143872] [SOUP] Add initial implementation of NetworkProcess disk cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143872

--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 251014
  --> https://bugs.webkit.org/attachment.cgi?id=251014
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251014&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:114
> +    Data(SoupBuffer*, Backing = Backing::Buffer);

Could this be a GRefPtr<SourceBuffer>&& to make memory management clearer?

> Source/WebKit2/NetworkProcess/cache/NetworkCacheDataSoup.cpp:56
> +    return { buffer.get() };

then this would be a return { WTF::move(buffer) };

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150417/e30c14c6/attachment.html>