[Webkit-unassigned] [Bug 143826] Use CommonCrypto for SHA1 and MD5

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143826

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 250918
  --> https://bugs.webkit.org/attachment.cgi?id=250918
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250918&action=review

> Source/WTF/ChangeLog:22
> +            Remove the side effect where computeHash resets the state. No one relies on it.

All I see is the comment change and the new CommonCrypto. I don’t see a code change that makes that change for the non-CommonCrypto version. Is the idea that now computeHash might reset the state and might not? I think this is slightly untidy right now. I don’t know what the rules are about what you can and can’t do after calling computeHash and what behavior you should expect.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150417/bd394db0/attachment.html>