[Webkit-unassigned] [Bug 143749] Force mouse events should go through normal mouse event handling code paths
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 16 12:20:19 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=143749
--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 250904
--> https://bugs.webkit.org/attachment.cgi?id=250904
Patch with tests
View in context: https://bugs.webkit.org/attachment.cgi?id=250904&action=review
> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:294
> + EventSenderPressureEvent *firstEvent = [[EventSenderPressureEvent alloc] initAtLocation:NSMakePoint(m_position.x, m_position.y)
> + globalLocation:([m_testController->mainWebView()->platformWindow() convertRectToScreen:NSMakeRect(m_position.x, m_position.y, 1, 1)].origin)
> + stage:1
> + pressure:0.9
> + phase:NSEventPhaseChanged
> + time:absoluteTimeForEventTime(currentEventTime())
> + eventNumber:++eventNumber];
> + EventSenderPressureEvent *secondEvent = [[EventSenderPressureEvent alloc] initAtLocation:NSMakePoint(m_position.x, m_position.y)
> + globalLocation:([m_testController->mainWebView()->platformWindow() convertRectToScreen:NSMakeRect(m_position.x, m_position.y, 1, 1)].origin)
> + stage:2
> + pressure:0.1
> + phase:NSEventPhaseChanged
> + time:absoluteTimeForEventTime(currentEventTime())
> + eventNumber:++eventNumber];
Is this file using ARC? If not, these are leaked.
> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:327
> + EventSenderPressureEvent *firstEvent = [[EventSenderPressureEvent alloc] initAtLocation:NSMakePoint(m_position.x, m_position.y)
> + globalLocation:([m_testController->mainWebView()->platformWindow() convertRectToScreen:NSMakeRect(m_position.x, m_position.y, 1, 1)].origin)
> + stage:2
> + pressure:0.1
> + phase:NSEventPhaseChanged
> + time:absoluteTimeForEventTime(currentEventTime())
> + eventNumber:++eventNumber];
> + EventSenderPressureEvent *secondEvent = [[EventSenderPressureEvent alloc] initAtLocation:NSMakePoint(m_position.x, m_position.y)
> + globalLocation:([m_testController->mainWebView()->platformWindow() convertRectToScreen:NSMakeRect(m_position.x, m_position.y, 1, 1)].origin)
> + stage:1
> + pressure:0.9
> + phase:NSEventPhaseChanged
> + time:absoluteTimeForEventTime(currentEventTime())
> + eventNumber:++eventNumber];
Ditto.
> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:353
> + EventSenderPressureEvent *event = [[EventSenderPressureEvent alloc] initAtLocation:NSMakePoint(m_position.x, m_position.y)
> + globalLocation:([m_testController->mainWebView()->platformWindow() convertRectToScreen:NSMakeRect(m_position.x, m_position.y, 1, 1)].origin)
> + stage:force < 1 ? 1 : 2
> + pressure:force
> + phase:NSEventPhaseChanged
> + time:absoluteTimeForEventTime(currentEventTime())
> + eventNumber:++eventNumber];
Ditto.
> LayoutTests/ChangeLog:10
> + Just a few new tests. More to come.
Would be nice to get testing of at least:
* bubbling
* preventDefault
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150416/fc302ca6/attachment.html>
More information about the webkit-unassigned
mailing list