[Webkit-unassigned] [Bug 143831] New: [CMake] Require specifying visibility of WebKit options

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143831

            Bug ID: 143831
           Summary: [CMake] Require specifying visibility of WebKit
                    options
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: PC
                OS: All
            Status: NEW
          Severity: Enhancement
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com

It's not clear that WEBKIT_OPTION_DEFINE defines a private option or that WEBKIT_OPTION_DEFAULT_PORT_VALUE makes the option public. This was probably a mistake: let's require the user to choose PUBLIC or PRIVATE when defining or overriding the option. This also removes the short-lived WEBKIT_OPTION_DEFINE_PUBLIC and WEBKIT_OPTION_PRIVATE_PORT_VALUE macros.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150416/e094f364/attachment.html>