[Webkit-unassigned] [Bug 143771] [W32] windowsVersion() and osVersionForUAString() are outdated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 15 10:16:05 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=143771

WebKit Commit Bot <commit-queue at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |commit-queue at webkit.org

--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org> ---
Attachment 250818 did not pass style-queue:


ERROR: Source/WebCore/platform/win/SystemInfo.cpp:74:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/win/SystemInfo.cpp:82:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/ChangeLog:16:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150415/524a52b1/attachment.html>


More information about the webkit-unassigned mailing list