[Webkit-unassigned] [Bug 143750] Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 15 08:59:10 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=143750

--- Comment #6 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
Comment on attachment 250791
  --> https://bugs.webkit.org/attachment.cgi?id=250791
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250791&action=review

> Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp:65
> +#if !ENABLE(NOTIFICATIONS) && !ENABLE(LEGACY_NOTIFICATIONS)

I don't like to use unnecessary macro. Probably it looks Ossy wants to use a thing similar to below style. 

NotificationPermissionRequestManager::NotificationPermissionRequestManager(WebPage* page)
{
#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
    m_page = page;
#else
    UNUSED_PARAM(page);
#endif
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150415/9777a2dc/attachment.html>


More information about the webkit-unassigned mailing list