[Webkit-unassigned] [Bug 143056] Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ResourceResponse

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 13 00:56:03 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=143056

--- Comment #8 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
Comment on attachment 249460
  --> https://bugs.webkit.org/attachment.cgi?id=249460
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249460&action=review

>>> Source/WebCore/loader/WorkerThreadableLoader.cpp:93
>>> +    CrossThreadResourceRequestData* requestData = request.copyData().release();
>> 
>> Why do you change auto with CrossThreadResourceRequestData* ?
> 
> I thought that it's not a type of std::unique_ptr but raw pointer, so I changed it back to raw pointer type. Do you think it would be better to use auto* here?

yes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150413/3b24a283/attachment.html>


More information about the webkit-unassigned mailing list