[Webkit-unassigned] [Bug 143640] New: [GTK] Useless code in OptionsGTK.cmake

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 11 19:21:22 PDT 2015


            Bug ID: 143640
           Summary: [GTK] Useless code in OptionsGTK.cmake
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com

In OptionsGTK.cmake we have this:

# This part can be simplified once CMake 2.8.6 is required and
# CMakePushCheckState can be used. We need to have OPENGL_INCLUDE_DIR as part
# of the directories check_include_files() looks for in case OpenGL is
# installed into a non-standard location.

endif ()

Which does nothing. This broke sometime recentlyish when the check for GLX moved elsewhere in the file. Should be:

# We don't use find_package for GLX because it is part of -lGL, unlike EGL.
check_include_files("GL/glx.h" GLX_FOUND)

I will fix this in bug #143558, since it is hard to split my changes to OptionsGTK.cmake into multiple patches. I'm filing this bug just to make sure we don't lose track of it.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150412/d93dd7aa/attachment-0001.html>

More information about the webkit-unassigned mailing list