[Webkit-unassigned] [Bug 143621] Hide volume controls when playing wirelessly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 10 19:49:32 PDT 2015


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #250540|review?                     |review+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 250540
  --> https://bugs.webkit.org/attachment.cgi?id=250540

View in context: https://bugs.webkit.org/attachment.cgi?id=250540&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1776
> +                if (!this.controls.panel.contains(this.controls.volumeBox))

Would it be more efficient to check the parent of volumeBox rather than calling contains?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150411/b7d9251c/attachment.html>

More information about the webkit-unassigned mailing list