[Webkit-unassigned] [Bug 141692] Web Inspector: Styles sidebar editing with incomplete property looks poor in UI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141692

--- Comment #21 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 250537
  --> https://bugs.webkit.org/attachment.cgi?id=250537
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250537&action=review

I'll let Joe look at this for actual substance.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:790
> +    }
> +
>      _resetContent()

Nit: Extra newline.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:853
> +                 });
> +                return;

Nit: Newline.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:859
> +            // Now the Formatter pretty prints the styles.
> +            editor.setValue(this._formattedContentFromEditor());

I'd put a newline before the comment.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:896
> +            this._markLinesWithCheckboxPlaceholder();
> +
>          }

Nit: Extra newline.

> Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js:34
> +        return false;
> +    },

Nit: Newline.

> Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js:312
> +    },
>      shouldHaveSpaceBeforeToken: function(lastToken, lastContent, token, state, content, isComment)

Ditto.

> Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js:439
> +    },
> +    shouldHaveSpaceBeforeToken: function(lastToken, lastContent, token, state, content, isComment)

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150410/35d3c8e0/attachment.html>