[Webkit-unassigned] [Bug 137973] Disable Linux-specific code in a Windows build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 9 11:35:34 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=137973

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240906|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #9 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 240906
  --> https://bugs.webkit.org/attachment.cgi?id=240906
proposed wk patch ]I[

View in context: https://bugs.webkit.org/attachment.cgi?id=240906&action=review

> Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:152
> +#if OS(DARWIN) || (OS(LINUX) && !defined(__UCLIBC__))

Based on wtf/Assertions.cpp, which has:

    #if OS(DARWIN) || OS(LINUX)
    #  if PLATFORM(GTK)
    #    if defined(__GLIBC__) && !defined(__UCLIBC__)
    #      define WTF_USE_BACKTRACE_SYMBOLS 1
    #    endif
    #  else
    #    define WTF_USE_DLADDR 1
    #  endif
    #endif

This should probably be:

    #if OS(DARWIN) || (OS(LINUX) && !PLATFORM(GTK))

Same up above in the includes. Do you agree?

> Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:177
> +        UNUSED_PARAM(callStack);

Nit: Too much indentation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150409/87a0134a/attachment-0001.html>


More information about the webkit-unassigned mailing list