[Webkit-unassigned] [Bug 141028] Crash in JSC::DFG::StackLayoutPhase::run

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 8 15:10:09 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=141028

--- Comment #6 from Filip Pizlo <fpizlo at apple.com> ---
(In reply to comment #5)
> Comment on attachment 245915 [details]
> Patch
> 
> Should we still take these additional regression tests, since they
> presumably cover something that was not covered before?

Nah.

Previously, if you said "arguments" then the whole compiler - every compiler in every tier - would flip into this alternate reality world.  So we were steadily converging towards having two versions of every test: one that said "arguments" and one that didn't.

This isn't true anymore.  Saying "arguments" only changes how the arguments themselves are accessed but after bytecode generation, none of the tiers really care.

So, having tests for recursion using apply where you say "arguments" isn't really useful.  There's nothing special about that anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150408/68e756ac/attachment.html>


More information about the webkit-unassigned mailing list